Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep percentage type's range is 0%~100% #11271

Merged
merged 2 commits into from Jul 14, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Jul 14, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10551

  1. Keep percentage range is 0%~100%.
  2. fix fill_default raw_conf crash when check_process_watermark.

Summary

馃 Generated by Copilot at 11ee6ab

This pull request adds support for percent values in the configuration schema, and fixes a bug that caused the filter_readonly_config function to crash when the configuration was invalid or incomplete. It modifies the files emqx_schema.erl and emqx_conf_cli.erl.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested review from a team and lafirest as code owners July 14, 2023 08:55
@zhongwencool zhongwencool merged commit f853f3d into emqx:release-51 Jul 14, 2023
122 checks passed
@zhongwencool zhongwencool deleted the fix-precent-check branch July 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants