-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shared_sub): restore support for $queue/
shared subscription
#11281
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -187,8 +187,10 @@ format(WhichNode, {{Topic, _Subscriber}, Options}) -> | |
maps:with([qos, nl, rap, rh], Options) | ||
). | ||
|
||
get_topic(Topic, #{share := <<"$queue">> = Group}) -> | ||
filename:join([Group, Topic]); | ||
get_topic(Topic, #{share := Group}) -> | ||
emqx_topic:join([<<"$share">>, Group, Topic]); | ||
filename:join([<<"$share">>, Group, Topic]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably not what we want, i.e. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! 鉁旓笍 |
||
get_topic(Topic, _) -> | ||
Topic. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Restored support for the special `$queue/` shared subscription. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe add why it's not working (or what it needs to work)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few comments in other places, and the PR number can be referenced from the merge commit, I guess.