fix(oracle): discard nested tokens when checking table #11307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulozulato
force-pushed
the
fix-oracle-table-check
branch
from
00e760b
to
6bf3b26
Compare
paulozulato
changed the title
thalesmg
previously approved these changes
Jul 19, 2023
paulozulato
force-pushed
the
fix-oracle-table-check
branch
from
6bf3b26
to
a177410
Compare
paulozulato
force-pushed
the
fix-oracle-table-check
branch
from
a177410
to
e76ba76
Compare
|
After the fix:
|
thalesmg
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting release-51
Fixes https://emqx.atlassian.net/browse/EMQX-10597
Summary
馃 Generated by Copilot at 00e760b
Updated the version number of
emqx_oracleand fixed a bug with nested tokens in the SQL statement. The bug caused the bridge probe to fail when checking if the table exists.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfiles[ ] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up[ ] Schema changes are backward compatibleChecklist for CI (.github/workflows) changes
[ ] If changed package build workflow, pass this action (manual trigger)[ ] Change log has been added tochanges/dir for user-facing artifacts update