New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(machine_boot): use shared list of reboot apps and add bridges to reboot list #11309
fix(machine_boot): use shared list of reboot apps and add bridges to reboot list #11309
Conversation
3c67988
to
0351c13
Compare
BusinessApps = CommonBusinessApps ++ EditionSpecificApps, | ||
?BASIC_REBOOT_APPS ++ BusinessApps. | ||
|
||
filter(AppList, Filters) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need a ./configure step for the build...
0351c13
to
b9b11d8
Compare
observer | ||
], | ||
%% must always be of type `load' | ||
ee_business_apps => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should split ee_business_apps to a different apps' prive dir. apps/emqx_enteriprise/priv/
In order to don't include enterprise in community version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emqx_machine_boot:basic_reboot_apps()
on ce already mentions some ee apps on master.
But I agree that we can further improve it later.
I just noticed that starting a node might result in some noisy logs when there are existing bridges because their dependencies (e.g.: |
8b81d48
to
493f1e5
Compare
We need to reverse the dependency of `emqx_bridge` and `emqx_bridge_*`, because the former loads and starts bridges during its application startup. If the individual bridge application being loaded has not started with its dependencies, the supervision tree will not be ready for that.
493f1e5
to
6cd5038
Compare
Ensures all business applications are restarted when the node joins a cluster.
Also, unifies the apps lists in a single place to avoid repetition in
mix.exs
andrebar.config.erl
.Summary
🤖 Generated by Copilot at 3191dd0
This pull request improves the application rebooting mechanism of the
emqx_machine
project by using a configurableeterm
file instead of a fixed list. It also updates themix.exs
,rebar.config.erl
andMakefile
files to support the new mechanism and enhance the project compatibility and flexibility.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update