Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ds): avoid crashes when starting on Windows #11352

Merged
merged 3 commits into from Jul 27, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Jul 26, 2023

Fixes #11345

Summary

馃 Generated by Copilot at 14b7691

This pull request fixes a crash issue and adds a workaround for using emqx_durable_storage on Windows. It changes the storage option for mria to disc_copies and updates the version number to 0.1.2.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest force-pushed the fix/ds_crash branch 2 times, most recently from 52aa860 to d8805db Compare July 26, 2023 07:53
@lafirest lafirest marked this pull request as ready for review July 26, 2023 09:14
@lafirest lafirest requested review from a team, ieQu1 and keynslug as code owners July 26, 2023 09:14
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5666537510

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 22 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.01%) to 81.582%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_durable_storage/src/emqx_ds_app.erl 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
apps/emqx_dashboard/src/emqx_dashboard_desc_cache.erl 1 94.44%
apps/emqx_ft/src/emqx_ft_storage_exporter_fs.erl 1 80.43%
apps/emqx_gateway/src/emqx_gateway_utils.erl 1 86.49%
apps/emqx/src/emqx_broker.erl 1 88.33%
apps/emqx/src/emqx_quic_stream.erl 1 75.0%
apps/emqx_oracle/src/emqx_oracle.erl 2 81.01%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 2 93.54%
apps/emqx/src/emqx_alarm.erl 2 89.92%
apps/emqx/src/emqx_trace/emqx_trace.erl 2 88.18%
apps/emqx/src/emqx_reason_codes.erl 9 92.65%
Totals Coverage Status
Change from base Build 5660488143: 0.01%
Covered Lines: 31255
Relevant Lines: 38311

馃挍 - Coveralls

@zhongwencool zhongwencool merged commit a3a1a04 into emqx:master Jul 27, 2023
141 checks passed
@lafirest lafirest deleted the fix/ds_crash branch July 27, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closed soon after started
4 participants