Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rabbitmq_bridge): add TLS support #11363

Merged
merged 1 commit into from Jul 28, 2023

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Jul 27, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10605

Summary

馃 Generated by Copilot at f4b5086

This pull request adds TLS support for the emqx_bridge_rabbitmq connector, which allows EMQX to securely communicate with RabbitMQ over TLS. It also updates the test suite and the docker-compose file to enable and verify the TLS feature. Finally, it bumps the version of the emqx_bridge_rabbitmq application.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [na] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • [na] Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [na] If changed package build workflow, pass this action (manual trigger)
  • [na] Change log has been added to changes/ dir for user-facing artifacts update

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5684373595

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.004%) to 81.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_bridge_rabbitmq/src/emqx_bridge_rabbitmq_connector.erl 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
apps/emqx_ft/src/emqx_ft_storage_exporter_fs.erl 1 80.43%
apps/emqx_gateway_exproto/src/emqx_exproto_gcli.erl 1 64.15%
apps/emqx/src/emqx_connection.erl 1 83.47%
apps/emqx/src/emqx_quic_data_stream.erl 1 75.21%
apps/emqx_gateway_mqttsn/src/emqx_mqttsn_frame.erl 2 62.92%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 2 93.54%
apps/emqx/src/emqx_trace/emqx_trace.erl 2 88.18%
apps/emqx_resource/src/emqx_resource_metrics.erl 4 53.68%
apps/emqx/src/emqx_alarm_handler.erl 5 31.82%
apps/emqx/src/emqx_reason_codes.erl 11 88.97%
Totals Coverage Status
Change from base Build 5683125242: 0.004%
Covered Lines: 31335
Relevant Lines: 38425

馃挍 - Coveralls

@thalesmg thalesmg marked this pull request as ready for review July 27, 2023 20:13
@thalesmg thalesmg requested a review from a team as a code owner July 27, 2023 20:13
@thalesmg thalesmg merged commit d6344ab into emqx:master Jul 28, 2023
143 checks passed
@thalesmg thalesmg deleted the rabbit-tls-20230727 branch July 28, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants