feat(mongodb): add configurable option to override legacy protocol usage #11429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
mongodb-legacy-opt-20230810
branch
from
af90f82
to
0db0ff0
Compare
thalesmg
force-pushed
the
mongodb-legacy-opt-20230810
branch
from
0db0ff0
to
c533243
Compare
thalesmg
requested review from
lafirest,
a team,
JimMoen and
savonarola
as code owners
ieQu1
reviewed
Aug 14, 2023
ieQu1
previously approved these changes
Aug 14, 2023
thalesmg
force-pushed
the
mongodb-legacy-opt-20230810
branch
from
c533243
to
d93e1bb
Compare
paulozulato
approved these changes
Aug 14, 2023
Comment on lines
+523
to
+533
| {ok, _} = create_bridge(Config, #{<<"use_legacy_protocol">> => <<"true">>}), | ||
| ?retry( | ||
| _Interval0 = 200, | ||
| _NAttempts0 = 20, | ||
| ?assertMatch({ok, connected}, emqx_resource_manager:health_check(ResourceID)) | ||
| ), | ||
| WorkerPids0 = get_worker_pids(Config), | ||
| Expected0 = maps:from_keys(WorkerPids0, true), | ||
| LegacyOptions0 = maps:from_list([{Pid, mc_utils:use_legacy_protocol(Pid)} || Pid <- WorkerPids0]), | ||
| ?assertEqual(Expected0, LegacyOptions0), | ||
| {ok, _} = delete_bridge(Config), |
There was a problem hiding this comment.
nit: maybe put it in a fun?
There was a problem hiding this comment.
It's only used here twice, so I don't think it's worth doing it at this point. If it starts getting used more often, it's a good idea.
lafirest
reviewed
Aug 15, 2023
lafirest
approved these changes
Aug 15, 2023
|
is it still needed after the client is fixed? |
|
bump mongo client version ? |
I think it is better to have the option to customize it if needed, even if the auto mechanism is improved.
It is bumped: |
zhongwencool
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-10750
Fixes #11428
See emqx/mongodb-erlang#39
Summary
馃 Generated by Copilot at af90f82
Added support for different MongoDB protocol versions in the emqx_mongodb and emqx_bridge_mongodb applications. Updated the dependency, test case, configuration, and i18n files accordingly. Bumped the versions of the affected applications.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update