feat: change mqtt.max_packet_size type from string to bytesize #11438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongwencool
force-pushed
the
max-packet-size-validate
branch
from
b2e687d
to
5822f43
Compare
zhongwencool
force-pushed
the
max-packet-size-validate
branch
from
5822f43
to
e10f9e5
Compare
zhongwencool
requested review from
JimMoen,
lafirest and
a team
as code owners
|
|
lafirest
previously approved these changes
Aug 14, 2023
HJianBo
previously approved these changes
Aug 14, 2023
id
reviewed
Aug 14, 2023
apps/emqx/src/emqx_schema.erl
Outdated
| @@ -2618,6 +2616,16 @@ validate_heap_size(Siz) when is_integer(Siz) -> | |||
| validate_heap_size(_SizStr) -> | |||
| {error, invalid_heap_size}. | |||
|
|
|||
| validate_packet_size(Siz) when is_integer(Siz) andalso Siz < 1 -> | |||
| {error, #{reason => max_heap_size_too_small, minimum => 1}}; | |||
There was a problem hiding this comment.
Suggested change
| {error, #{reason => max_heap_size_too_small, minimum => 1}}; | |
| {error, #{reason => max_packet_size_too_small, minimum => 1}}; |
?
apps/emqx/src/emqx_schema.erl
Outdated
| {error, #{reason => max_heap_size_too_small, minimum => 1}}; | ||
| validate_packet_size(Siz) when is_integer(Siz) andalso Siz > ?MAX_INT_MQTT_PACKET_SIZE -> | ||
| Max = integer_to_list(round(?MAX_INT_MQTT_PACKET_SIZE / 1024 / 1024)) ++ "M", | ||
| {error, #{reason => max_heap_size_too_large, maximum => Max}}; |
There was a problem hiding this comment.
Suggested change
| {error, #{reason => max_heap_size_too_large, maximum => Max}}; | |
| {error, #{reason => max_packet_size_too_large, maximum => Max}}; |
?
id
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-10587
It鈥檚 more friendly to Frontend to design the range validation.
Before:
After:
Summary
馃 Generated by Copilot at b2e687d
This pull request refactors the schema validation of the
max_packet_sizeparameter, removes the unusedmqtt_max_packet_sizetype and function, and updates the version numbers of theemqx_dashboardandemqx_opentelemetryapplications. It also fixes the format of the cluster gauge metric in theemqx_otelmodule.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update