Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty cacertfile pem #11456

Merged
merged 2 commits into from Aug 16, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Aug 16, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10760

Summary

馃 Generated by Copilot at b733adc

Refactor and improve SSL options handling for emqx. Use atoms instead of strings for SSL options schema, allow empty cacertfile option, and enhance error handling and testing for SSL files.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested review from lafirest and a team as code owners August 16, 2023 12:16
@zhongwencool zhongwencool merged commit e406cd7 into emqx:master Aug 16, 2023
128 checks passed
@zhongwencool zhongwencool deleted the allow-empty-cacertfile-pem branch August 16, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants