Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): fix result handling when sending message with invalid header #11508

Merged

Conversation

paulozulato
Copy link
Contributor

@paulozulato paulozulato commented Aug 23, 2023

Targeting release-52

Fixes https://emqx.atlassian.net/browse/EMQX-10846

Summary

馃 Generated by Copilot at c2892a6

This pull request improves the Kafka bridge producer by adding instance id tracking, error handling, and code refactoring. It also fixes a bug in the GCP PubSub bridge producer that prevented boolean values in headers. It also adds a new test case for the Kafka bridge producer to verify the error handling.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • [na] Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [na] Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • [na] Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [na] If changed package build workflow, pass this action (manual trigger)
  • [na] Change log has been added to changes/ dir for user-facing artifacts update

@paulozulato paulozulato force-pushed the fix-azure-msg-error-handling branch 4 times, most recently from f4bcae8 to cd55df4 Compare August 24, 2023 02:25
@paulozulato paulozulato marked this pull request as ready for review August 24, 2023 13:18
@paulozulato paulozulato requested a review from a team as a code owner August 24, 2023 13:18
thalesmg
thalesmg previously approved these changes Aug 24, 2023
changes/ee/fix-11508.en.md Outdated Show resolved Hide resolved
@paulozulato paulozulato merged commit 84e68f8 into emqx:release-52 Aug 25, 2023
128 checks passed
@paulozulato paulozulato deleted the fix-azure-msg-error-handling branch August 25, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants