Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the suggest msg for update conf failed #11523

Merged
merged 3 commits into from Aug 28, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Aug 25, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10834

  • For certificates and keys that cannot be "", the prompt is very misunderstood
Tips: There may be some conflicts in the new configuration under `merge` mode,
Please retry with the `replace` mode.
  • mute the /configs/ API ununcessary log to console.

Summary

馃 Generated by Copilot at b1221e8

This pull request refactors the config loading commands and API to use a map of options instead of an atom for the loading mode. This enables the user to control the output of the commands and suppresses the output for the API. It also improves the error handling and suggestion messages for the config loading commands.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool marked this pull request as ready for review August 28, 2023 03:29
@zhongwencool zhongwencool merged commit d7f6d02 into emqx:release-52 Aug 28, 2023
130 checks passed
@zhongwencool zhongwencool deleted the emqx-conf-suggest-message branch August 28, 2023 06:44
@@ -0,0 +1 @@
Fixes misunderstood prompt when invalid certificates/keys were specified for the `/configs` API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misunderstood -> misleading ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants