Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frame): improve some error reasons when parsing invalid packet #11532

Merged
merged 2 commits into from Aug 30, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Aug 28, 2023

Fixes EMQX-10528

Summary

馃 Generated by Copilot at 333528d

Improve error handling of malformed MQTT packets in emqx_frame.erl. Add more details to error messages and prevent badmatch exceptions.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review August 29, 2023 05:57
@lafirest lafirest requested a review from a team as a code owner August 29, 2023 05:57
apps/emqx/src/emqx_frame.erl Outdated Show resolved Hide resolved
changes/ce/perf-11532.en.md Outdated Show resolved Hide resolved
apps/emqx/test/emqx_ws_connection_SUITE.erl Outdated Show resolved Hide resolved
@lafirest lafirest merged commit 8b3a907 into emqx:master Aug 30, 2023
130 checks passed
@lafirest lafirest deleted the fix/frame_parse branch August 30, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants