fix(plugins): update plugin order on whole cluster #11548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
fix-plugin-order-update-r52-20230830
branch
from
8e51162
to
a546fee
Compare
thalesmg
force-pushed
the
fix-plugin-order-update-r52-20230830
branch
from
a546fee
to
4dfbc85
Compare
thalesmg
requested review from
JimMoen,
a team,
lafirest and
sstrigler
as code owners
zmstone
reviewed
Aug 31, 2023
| @@ -240,28 +241,34 @@ ensure_enabled(NameVsn) -> | |||
| %% @doc Ensure a plugin is enabled at the given position of the plugin list. | |||
| -spec ensure_enabled(name_vsn(), position()) -> ok | {error, any()}. | |||
| ensure_enabled(NameVsn, Position) -> | |||
| ensure_state(NameVsn, Position, true). | |||
| ensure_state(NameVsn, Position, _Enabled = true, _ConfLocation = local). | |||
There was a problem hiding this comment.
The current state of the code is already to use local here, and some places like management API do a multicall RPC. So the default is local to keep this change minimally invasive.
Also, post_config_update might also call some of those functions, and it should be local as well. See #8254 for a related issue that was fixed.
There was a problem hiding this comment.
multicall for conf change is maybe unintentional and should be fixed to use cluster-call
zmstone
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targeting
release-52Fixes https://emqx.atlassian.net/browse/EMQX-10879
Summary
馃 Generated by Copilot at 8e51162
This pull request adds a new feature of global plugin configuration to the
emqx_pluginsapplication and updates the test code and the command line interface to support it. It also improves the dashboard API test code by introducing a new helper function and refactoring an existing one.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update