Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade jq library #11565

Merged
merged 2 commits into from Oct 30, 2023

Conversation

kjellwinblad
Copy link
Contributor

@kjellwinblad kjellwinblad commented Sep 5, 2023

In this commit the jq library is upgraded from v0.3.10 to v0.3.11. The new version has the following changes:

  • The jq port programs is only started on demand
    • this means that users will not see jq_port in their processes list if they have not used the jq function in EMQX
  • The jq port programs are terminated automatically if they are idle for a long enough time period

The default for EMQX is to run the jq library in NIF mode so most users will not be affected by this change.

Fixes:
https://emqx.atlassian.net/browse/EMQX-10911

Summary

馃 Generated by Copilot at bc3f2e9

This pull request updates the jq dependency to the latest version in both mix.exs and rebar.config.erl files. This improves the JSON parsing and transformation capabilities of emqx.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • [] Added tests for the changes
  • [] Added property-based tests for code which performs user input validation
  • [] Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [] Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • [] Schema changes are backward compatible

In this commit the jq library is upgraded from v0.3.10 to v0.3.11.
The new version has the following changes:

* The jq port programs is only started on demand
  - this means that users will not see jq_port in their process list if
    they have not used the jq function in EMQX
* The jq port programs are terminated automatically if they are idle
  for a long enough time period

The default for EMQX is to run the jq library in NIF mode so most users
will not be affected by this change.

Fixes:
https://emqx.atlassian.net/browse/EMQX-10911
@kjellwinblad kjellwinblad requested a review from a team as a code owner September 5, 2023 11:32
ieQu1
ieQu1 previously approved these changes Sep 5, 2023
qzhuyan
qzhuyan previously approved these changes Sep 5, 2023
thalesmg
thalesmg previously approved these changes Sep 5, 2023
paulozulato
paulozulato previously approved these changes Sep 5, 2023
@id id changed the base branch from release-52 to master September 13, 2023 09:06
@id id dismissed stale reviews from paulozulato, thalesmg, qzhuyan, and ieQu1 September 13, 2023 09:06

The base branch was changed.

@kjellwinblad kjellwinblad changed the base branch from master to release-53 October 30, 2023 13:42
@kjellwinblad kjellwinblad reopened this Oct 30, 2023
@kjellwinblad kjellwinblad changed the base branch from release-53 to master October 30, 2023 14:23
@kjellwinblad kjellwinblad changed the base branch from master to release-53 October 30, 2023 14:23
@kjellwinblad kjellwinblad merged commit 290c433 into emqx:release-53 Oct 30, 2023
295 of 297 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants