Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: telemetry report error on windows #11584

Merged
merged 1 commit into from Sep 21, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Sep 11, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10938
os_mon is not included on windows, so the SysMemData = memsup:get_system_memory_data() always report error:
module could not be loaded.

image

Summary

馃 Generated by Copilot at a2b06f4

Improved the reliability and portability of the emqx_telemetry application by using emqx_mgmt:vm_stats instead of memsup:get_system_memory_data to get the system memory. Added a test case to cover the scenario where os_mon is not available. Bumped the version number to 0.1.2.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool force-pushed the telemetry-error-on-windows branch 2 times, most recently from d2e69bc to 2454cfd Compare September 11, 2023 06:51
@zhongwencool zhongwencool marked this pull request as ready for review September 11, 2023 06:51
@zhongwencool zhongwencool requested a review from a team as a code owner September 11, 2023 06:51
@zhongwencool zhongwencool merged commit 9521e11 into emqx:master Sep 21, 2023
128 of 130 checks passed
@zhongwencool zhongwencool deleted the telemetry-error-on-windows branch September 21, 2023 01:08
@zhongwencool zhongwencool mentioned this pull request Sep 21, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants