Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

0913 lower severity level for cmd override warnings #11605

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Sep 13, 2023

Fixes EMQX-10964

Summary

馃 Generated by Copilot at 95f1312

Changed the log level of CMD_overridden message from warning to info in emqx_ctl.erl. This makes the log file less noisy and more clear about the configuration precedence.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

prior to this change this warning message is always logged if a node
joins cluster.

the intention of this warning is to detect potential command name
clash (provided by different plugins), so arguably it should be
at debug level
@zmstone zmstone requested a review from a team as a code owner September 13, 2023 18:54
@zmstone zmstone merged commit a9682c2 into emqx:master Sep 16, 2023
131 checks passed
@zmstone zmstone deleted the 0913-lower-severity-level-for-CMD-override-warnings branch September 16, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants