Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqx_bridge_hstreamdb): fix resources cleanup in on_stop/2 cb #11627

Merged

Conversation

SergeTupchiy
Copy link
Contributor

@SergeTupchiy SergeTupchiy commented Sep 18, 2023

Fixes EMQX-10962

Summary

馃 Generated by Copilot at da730e8

Fix a bug in emqx_bridge_hstreamdb_connector that caused a bad match error when stopping the bridge. Use a macro to match the hstreamdb resource type.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy force-pushed the EMQX-10962-fix_hstreamdb-bridge-on-stop branch from da730e8 to 80cf60e Compare September 18, 2023 14:48
@SergeTupchiy SergeTupchiy marked this pull request as ready for review September 18, 2023 14:49
@SergeTupchiy SergeTupchiy requested a review from a team as a code owner September 18, 2023 14:49
@SergeTupchiy SergeTupchiy merged commit 0b0e322 into emqx:master Sep 18, 2023
129 of 131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants