feat(dashboard): add SSO feature and integrate with LDAP #11631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimMoen
reviewed
Sep 19, 2023
lafirest
force-pushed
the
feat/dashboard_ldap
branch
2 times, most recently
from
b52ede0
to
3643424
Compare
lafirest
force-pushed
the
feat/dashboard_ldap
branch
from
3643424
to
6131108
Compare
zhongwencool
approved these changes
Sep 20, 2023
zmstone
reviewed
Sep 25, 2023
| Provider = emqx_dashboard_sso:provider(Backend), | ||
| case emqx_dashboard_sso:login(Provider, Sign, State) of | ||
| {ok, Token} -> | ||
| ?SLOG(info, #{msg => "Dashboard SSO login successfully", request => Sign}), |
zmstone
reviewed
Sep 25, 2023
| {role, | ||
| mk(binary(), #{desc => ?DESC(role), default => ?ROLE_DEFAULT, example => ?ROLE_DEFAULT})}; | ||
| field(backend) -> | ||
| {backend, mk(binary(), #{desc => ?DESC(backend), example => <<"local">>})}. |
zmstone
reviewed
Sep 25, 2023
| fun(Key, Acc) -> | ||
| case maps:find(Key, Config) of | ||
| {ok, Value} when is_binary(Value) -> | ||
| Acc#{Key := erlang:binary_to_list(Value)}; |
There was a problem hiding this comment.
why is 'timeout' a s string?
maybe add a comment here.
zmstone
reviewed
Sep 25, 2023
zmstone
reviewed
Sep 25, 2023
| emqx_utils_ets:new( | ||
| dashboard_sso, | ||
| [ | ||
| set, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
馃 Generated by Copilot at 2cddce5
This pull request adds a new application
emqx_dashboard_ssoto the enterprise edition of EMQX, which provides the functionality of single sign-on for the EMQX dashboard. It implements different single sign-on backends, such as LDAP, and integrates them with the existingemqx_dashboardandemqx_dashboard_adminmodules. It also adds the necessary configuration, documentation, license, and internationalization files for the new application.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update