Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ftconf): also mark secret_access_key key as sensitive #11676

Merged

Conversation

keynslug
Copy link
Contributor

@keynslug keynslug commented Sep 25, 2023

Fixes EMQX-11026.

Summary

馃 Generated by Copilot at 81cf619

Improve masking of sensitive keys in logs and configs. Add secret_access_key to the list of sensitive keys and handle different key types in emqx_utils:mask_config/1.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

@keynslug keynslug requested a review from a team as a code owner September 25, 2023 11:55
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6299000571

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.003%) to 82.752%

Files with Coverage Reduction New Missed Lines %
apps/emqx_connector/src/emqx_connector_jwt_worker.erl 1 89.47%
apps/emqx_ft/src/emqx_ft.erl 1 86.72%
apps/emqx_ft/src/emqx_ft_storage_exporter.erl 1 88.24%
apps/emqx_ft/src/emqx_ft_storage_fs.erl 1 82.84%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 1 93.26%
apps/emqx/src/emqx_cm.erl 1 90.32%
apps/emqx/src/emqx_connection.erl 1 83.15%
apps/emqx/src/emqx_limiter/src/emqx_limiter_schema.erl 1 85.71%
apps/emqx/src/emqx_os_mon.erl 1 91.78%
apps/emqx/src/emqx_router_helper.erl 1 88.68%
Totals Coverage Status
Change from base Build 6298036007: 0.003%
Covered Lines: 33614
Relevant Lines: 40620

馃挍 - Coveralls

@keynslug keynslug merged commit 349a6d9 into emqx:master Sep 25, 2023
133 checks passed
@keynslug keynslug deleted the fix/EMQX-11026/secret-access-key-sensitive branch September 25, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants