fix({kafka,pulsar}_producer): correctly handle metrics for connectors that have internal buffers #11724
+81
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
fix-kprodu-sync-metrics-m-20231006
branch
2 times, most recently
from
f991615
to
52bc762
Compare
thalesmg
changed the title
Pull Request Test Coverage Report for Build 6436313820
💛 - Coveralls |
9 tasks
thalesmg
changed the title
thalesmg
force-pushed
the
fix-kprodu-sync-metrics-m-20231006
branch
4 times, most recently
from
a1c17c0
to
7c690a1
Compare
… internal buffers Fixes https://emqx.atlassian.net/browse/EMQX-11086 There’s currently a metric inconsistency due to the internal buffering nature of Kafka Producer (wolff). We use simple_sync_query to call the Kafka Producer bridge. If that times out, the call is accounted as failed, even though the message is buffered in wolff and later sent successfully.
…ridges with internal buffering Since authn/authz backends also use simple async/sync queries, we may want to avoid them calling the connector when it's not connected.
…or Pulsar Since it has internal buffering, it necessitates the same fix as Kafka producer.
thalesmg
force-pushed
the
fix-kprodu-sync-metrics-m-20231006
branch
from
c3bd534
to
d6781ef
Compare
zmstone
reviewed
Oct 10, 2023
|
there is no need to keep the |
It was removed here: https://github.com/emqx/emqx/pull/11722/files#diff-3803c5a6f7df225ee8e37ccda7a79158464e838d842bd5632f25e6356fffb7c2L309 But there's still a reference to it in |
zmstone
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targeting
release-53Fixes https://emqx.atlassian.net/browse/EMQX-11086
There’s currently a metric inconsistency due to the internal buffering nature of Kafka Producer (wolff).
We use simple_sync_query to call the Kafka Producer bridge. If that times out, the call is accounted as failed, even though the message is buffered in wolff and later sent successfully.
Summary
🤖 Generated by Copilot at 887f0ad
This pull request adds a new query mode
simple_sync_internal_bufferto theemqx_resourceapplication, which enables synchronous queries with internal buffering and retry logic for resource workers that support it. This mode is used by the Kafka bridge producer to improve message delivery reliability. The pull request also updates the type definitions, version number, and query function of theemqx_resourceapplication.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update