fix(api-docs): add file-transfer config to hot-config scope #11731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynslug
reviewed
Oct 9, 2023
| @@ -38,12 +38,21 @@ | |||
| -define(OPTS, #{rawconf_with_defaults => true, override_to => cluster}). | |||
| -define(TAGS, ["Configs"]). | |||
|
|
|||
| -if(?EMQX_RELEASE_EDITION == ee). | |||
| -define(ROOT_KEYS_EE, [ | |||
| <<"file_transfer">> | |||
There was a problem hiding this comment.
File Transfer has its own configuration update mechanism nowadays, will this change provide essentially the same thing? Or is this exactly the goal here?
There was a problem hiding this comment.
Thank you for the tip. Will check with frontend team to see if it's good to take swagger spec for reference.
There was a problem hiding this comment.
The hotconf schema json is used by the dashboard to render UI.
zmstone
force-pushed
the
1008-expose-file-transfer-host-conf
branch
3 times, most recently
from
11e5980
to
395f697
Compare
zmstone
force-pushed
the
1008-expose-file-transfer-host-conf
branch
from
395f697
to
2626d79
Compare
Pull Request Test Coverage Report for Build 6466657156
馃挍 - Coveralls |
savonarola
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11108
Summary
馃 Generated by Copilot at c89c079
Added support for file transfer configuration in the enterprise edition and updated the emqx_management version number.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update