fix(cm): bring back pre-v5.3.0 compat in takeover_session_begin/1
#11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynslug
force-pushed
the
fix/EMQX-10827/sesson-takeover
branch
3 times, most recently
from
2850ffc
to
bfaf867
Compare
thalesmg
previously approved these changes
Oct 9, 2023
keynslug
force-pushed
the
fix/EMQX-10827/sesson-takeover
branch
from
5262874
to
2a31e4f
Compare
Which was accidentally broken in bf16417.
keynslug
force-pushed
the
fix/EMQX-10827/sesson-takeover
branch
from
2a31e4f
to
6301294
Compare
lafirest
approved these changes
Oct 10, 2023
zmstone
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which was accidentally broken in bf16417 as part of #11592.
Fixes EMQX-11095.
Summary
馃 Generated by Copilot at 3261e0a
Fix a bug that causes channel pid to be lost when a session is taken over by another node. Update
emqx_cm.erlto include channel pid in session takeover and stepdown messages.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesCreated PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket