Make IPv6 clustering options configurable #11734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
requested review from
kjellwinblad,
a team and
lafirest
as code owners
zmstone
force-pushed
the
1002-support-ipv6-only-clustering
branch
from
ffebcd1
to
5ceb2ee
Compare
So it can work with older version docker buildkit
Made possible to configure inet6_tls for Erlang distribution Also, added support to configure ipv6 listener for gen_rpc
* ekka 0.15.16 supports 'inet6_tls' as ekka.proto_dist * gen_rpc 3.2.0 supports true | false as gen_rpc.ipv6_only
zmstone
force-pushed
the
1002-support-ipv6-only-clustering
branch
from
5ceb2ee
to
bc3a57e
Compare
zmstone
force-pushed
the
1002-support-ipv6-only-clustering
branch
from
bc3a57e
to
d2af649
Compare
zmstone
force-pushed
the
1002-support-ipv6-only-clustering
branch
from
d2af649
to
d651764
Compare
qzhuyan
approved these changes
Oct 10, 2023
qzhuyan
reviewed
Oct 10, 2023
| sc( | ||
| string(), | ||
| #{ | ||
| default => "0.0.0.0", |
There was a problem hiding this comment.
I wonder if we need to do some address check if ipv6_only is true while listen_address is v4.
There was a problem hiding this comment.
chose to document the behaviour in desc:
ipv6_only only takes effect if listen_address is configured with a v6 address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11715
Jira: EMQX-11107
Release v/e5.3.1
Tried my best to test IPv6 in docker (also added to a commonly used clustering script),
however, I do not have a IPv6-ONLY environment to verify the newly if
rpc.ipv6_onlymust be set totruefor it to work properly.Worth noting that the clustering configs in general are not quite upgrade friendly.
For example, when changing from tcp to tls, rolling upgrade will not work.
Nonetheless, I tried my best to support
rpc.listen_addresschange from a IPv4 to a IPv6 address in a rolling upgrade.However, I did not verify rolling upgrade for
cluster.proto_distfrominet_tcptoinet6_tcpis supported.Summary
馃 Generated by Copilot at ffebcd1
This pull request adds IPv6 support for the cluster and RPC features of EMQX, updates the dependencies and i18n files, and improves the build and test scripts. It modifies the
emqx_conf_schema.erl,emqx_rule_funcs.erl,build,rel/i18n/emqx_conf_schema.hocon,scripts/test/start-two-nodes-in-docker.sh,.ci/docker-compose-file/pgsql/Dockerfile,apps/emqx/rebar.config, andmix.exsfiles.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update