Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authn): fix pbkdf2 option validation #11780

Merged
merged 1 commit into from Oct 30, 2023

Conversation

savonarola
Copy link
Contributor

@savonarola savonarola commented Oct 17, 2023

Fixes EMQX-10777

Also fixed a bug with password hashing made inside a transaction.

Summary

馃 Generated by Copilot at 364b3e2

This pull request fixes a bug and improves the validation and testing of the PBKDF2 hashing algorithm for password authentication. It changes the schema of the iterations parameter to pos_integer(), adds a guard clause to the hash function, and adds a test case for the schema validation.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • [na] Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Schema changes are NOT backward compatible. However, configurations that are now forbidden couldn't be functional.

@savonarola savonarola force-pushed the 1017-fix-pbkdf2-validation branch 3 times, most recently from c57b501 to 0e8302a Compare October 17, 2023 18:37
@savonarola savonarola marked this pull request as ready for review October 17, 2023 18:56
@savonarola savonarola requested review from JimMoen, a team and lafirest as code owners October 17, 2023 18:56
@savonarola savonarola closed this Oct 23, 2023
@savonarola savonarola reopened this Oct 23, 2023
@savonarola savonarola merged commit 3f6c09b into emqx:master Oct 30, 2023
142 of 145 checks passed
@savonarola savonarola deleted the 1017-fix-pbkdf2-validation branch October 30, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants