refactor(nodetool): only add libs when necessary #11787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11191
Summary
The
nodetool
command is started in a tempremsh
node which mostly issues RPC to the running EMQX node.For example,
ctl
,ping
andstatus
However,
hocon
andcheck_license_key
commands are executed locally (meaning there is no need for a running EMQX node in order to execute the command), so it needs to load all the apps before executing the command.Prior to this fix, the loading of the emqx apps is unconditional, the apps are loaded even if it's just a plain RPC call.
The fix is to only load apps for
hocon
andcheck_license_key
.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update