Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): improve redis command parsing and validation #11790

Merged

Conversation

savonarola
Copy link
Contributor

@savonarola savonarola commented Oct 18, 2023

Fixes EMQX-10193

Summary

馃 Generated by Copilot at 2fa717c

This pull request improves the Redis plugin for EMQX by adding a new module emqx_redis_command for parsing and validating Redis commands, using this module in the authentication and authorization backends, and adding more tests and validations for the Redis plugin. It also fixes some typos and inconsistencies in the code.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

@savonarola savonarola force-pushed the 1018-improve-redis-cmd-validation-in-auth branch 2 times, most recently from a07e8a2 to 96818db Compare October 18, 2023 13:22
@savonarola savonarola marked this pull request as ready for review October 18, 2023 13:22
@savonarola savonarola requested a review from a team as a code owner October 18, 2023 13:22
ieQu1
ieQu1 previously approved these changes Oct 19, 2023
@savonarola savonarola merged commit af6a364 into emqx:master Oct 20, 2023
141 checks passed
@savonarola savonarola deleted the 1018-improve-redis-cmd-validation-in-auth branch April 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants