Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen_rpc): ensure client/server use same driver #11796

Merged
merged 3 commits into from Oct 23, 2023

Conversation

qzhuyan
Copy link
Contributor

@qzhuyan qzhuyan commented Oct 20, 2023

Fix: https://emqx.atlassian.net/browse/EMQX-11185

  • ensure client/server use same driver
  • Also bump to gen_rpc 3.2.1

Fixes

Summary

馃 Generated by Copilot at dd5807b

Updated the gen_rpc dependency to version 3.2.1 and renamed the rpc.driver configuration key to rpc.protocol in emqx_conf_schema.erl. These changes were made to fix a bug in the RPC communication and to align with the latest gen_rpc library.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

ieQu1
ieQu1 previously approved these changes Oct 20, 2023
ieQu1
ieQu1 previously approved these changes Oct 20, 2023
@qzhuyan qzhuyan marked this pull request as ready for review October 20, 2023 21:00
@qzhuyan qzhuyan requested review from lafirest and a team as code owners October 20, 2023 21:00
@qzhuyan qzhuyan changed the base branch from master to release-53 October 20, 2023 21:01
@qzhuyan qzhuyan dismissed ieQu1鈥檚 stale review October 20, 2023 21:01

The base branch was changed.

@qzhuyan qzhuyan merged commit a9b42af into emqx:release-53 Oct 23, 2023
149 of 161 checks passed
@qzhuyan qzhuyan deleted the fix/william/gen_rpc-driver branch October 23, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants