New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rbac): for compatibility with old data schema, extend the existing field as an extra #11811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafirest
force-pushed
the
fix/api_rbac
branch
from
October 25, 2023 04:04
4235048
to
f8b6196
Compare
lafirest
force-pushed
the
fix/api_rbac
branch
from
October 25, 2023 05:58
f8b6196
to
3c4d915
Compare
if the bootstrap file format is documented in emqx-docs, please make sure the newly supported roles are documented. |
update desc here: emqx/rel/i18n/emqx_mgmt_api_key_schema.hocon Lines 9 to 13 in a4ab744
|
lafirest
force-pushed
the
fix/api_rbac
branch
2 times, most recently
from
October 26, 2023 02:36
55ad2a8
to
f181635
Compare
zmstone
reviewed
Oct 26, 2023
savonarola
reviewed
Oct 26, 2023
lafirest
force-pushed
the
fix/api_rbac
branch
2 times, most recently
from
October 27, 2023 07:38
172c8cb
to
2f2c45c
Compare
zmstone
reviewed
Oct 27, 2023
lafirest
force-pushed
the
fix/api_rbac
branch
from
October 27, 2023 09:17
2f2c45c
to
4ba34f8
Compare
zmstone
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
🤖 Generated by Copilot at e175c21
Refactor the
emqx_app
record and the backup and restore logic, and unify the role names for the dashboard and the management API. This reduces code duplication, improves readability, and simplifies the RBAC system.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update