Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rbac): for compatibility with old data schema, extend the existing field as an extra #11811

Merged
merged 4 commits into from Oct 27, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Oct 24, 2023

Fixes

Summary

🤖 Generated by Copilot at e175c21

Refactor the emqx_app record and the backup and restore logic, and unify the role names for the dashboard and the management API. This reduces code duplication, improves readability, and simplifies the RBAC system.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone
Copy link
Member

zmstone commented Oct 25, 2023

if the bootstrap file format is documented in emqx-docs, please make sure the newly supported roles are documented.

@zmstone
Copy link
Member

zmstone commented Oct 25, 2023

update desc here:

bootstrap_file.desc:
"""The bootstrap file provides API keys for EMQX.
EMQX will load these keys on startup to authorize API requests.
It contains key-value pairs in the format:`api_key:api_secret`.
Each line specifies an API key and its associated secret."""

@lafirest lafirest force-pushed the fix/api_rbac branch 2 times, most recently from 55ad2a8 to f181635 Compare October 26, 2023 02:36
@lafirest lafirest force-pushed the fix/api_rbac branch 2 times, most recently from 172c8cb to 2f2c45c Compare October 27, 2023 07:38
@lafirest lafirest merged commit e63602c into emqx:release-54 Oct 27, 2023
139 of 141 checks passed
@lafirest lafirest deleted the fix/api_rbac branch October 27, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants