Fix/william/genrpc ssl port align

[qzhuyan]

Fixes

Summary

🤖 Generated by Copilot at 6b9e8bc

This pull request introduces a new gen_rpc implementation for emqx nodes that supports SSL/TLS and two modes of port discovery. It also adds a new configuration option ssl_client_port and updates the helm charts to expose the new ports.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

• Added tests for the changes
• Added property-based tests for code which performs user input validation
• Changed lines covered in coverage report
• Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
• For internal contributor: there is a jira ticket to track this change
• Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
• Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

• If changed package build workflow, pass this action (manual trigger)
• Change log has been added to changes/ dir for user-facing artifacts update

[zmstone]

there should be no need for this. ?

[qzhuyan]

we need it for port port_discovery = stateless in gen_rpc, yes this is confusion.

[qzhuyan]

https://github.com/emqx/gen_rpc/blob/46dd22100391f3d87daca989cde7e2ecc52a17b5/README.md?plain=1#L117

[zmstone]

with the override set in docker entrypoint, i don't think we need this port.

[zmstone]

same here

[zmstone]

is this for redundance ? because it's set to manual in docker entrypoint script.
https://github.com/emqx/emqx/blob/master/deploy/docker/docker-entrypoint.sh#L52

[qzhuyan]

Oh I thought it was auto-discovery as it is the default in the schema. I set it to manual want to test both. shall we remove it from docker-entrypoint? I don't see good reason to have it there.

[qzhuyan]

or we should change the schema default to manual

[zmstone]

The override in docker entrypoint was added long ago, we keep it for backward compatibility reasons. (so that v4 and v5 has the same port mapping convention).

We cannot change the default in schema because for RPM/DEB/TGZ installation, it's offset based port mapping. --- also kept for backward compatibility reasons.

[zmstone]

this is probably the only change needed.

or fix this instead: gen_rpc has a default value for ssl clients to connect to 5370
https://github.com/emqx/gen_rpc/blob/46dd22100391f3d87daca989cde7e2ecc52a17b5/src/gen_rpc.app.src#L35

but we have set the same server port on 5369 for both tcp and ssl:

emqx/apps/emqx_conf/src/emqx_conf_schema.erl

Lines 798 to 813 in a4ab744

	{"tcp_server_port",
	sc(
	integer(),
	#{
	mapping => "gen_rpc.tcp_server_port",
	default => 5369,
	desc => ?DESC(rpc_tcp_server_port)
	}
	)},
	{"ssl_server_port",
	sc(
	integer(),
	#{
	mapping => "gen_rpc.ssl_server_port",
	default => 5369,
	desc => ?DESC(rpc_ssl_server_port)

[zmstone]

for completeness, we should actually add tcp_client_port too
otherwise manual will not work if one wants to change port for server.

[zmstone]

actually, to support manual strategy properly, it should not be a simple translation and user server port.
should rather make the tcp and ssl ports configurable for the clients.

[zmstone]

if we force all nodes in the cluster to use the same server port, then maybe just a translation is enough.

but please also add the same tr for tcp_client_port.