feat: Add arbitrary label support to helm chart for service serviceMonitors #11957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dounix
changed the title
Rory-Z
approved these changes
Nov 16, 2023
|
Hi @dounix great PR, could you please change your commit log to pass check |
|
@Rory-Z sure, everything but gcp pub/sub are passing now. |
|
@id any updates? |
|
@dounix I've rebased your branch on latest master and re-run the tests. Now everything is looking good. |
id
approved these changes
Dec 15, 2023
Yep thats great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11956
Summary
Adds service.labels support to emqx/emqx-enterprise helm chart
Changes to [deploy/charts/emqx-enterprise/templates/StatefulSet.yaml are a byproduct of the direction to run deploy/charts/sync-enterprise.sh after updating deploy/charts/emqx