fix(emqx_channel): do not log stale sock_close event as error #11975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
1119-fix-socket-close-race-condition
branch
from
eff79b3
to
ce84e83
Compare
In some cases, EMQX may decide to close socket and mark connection at 'disconnected' state, for example, when DISCONNECTE packet is received, or, when failed to write data to socket. However, by the time EMQX decided to close the socket, the socket might have already been closed by peer, and the `tcp_closed` envet is already delivered to the process mailbox -- causing EMQX to handle sock_close event at 'disconnected' state.
zmstone
force-pushed
the
1119-fix-socket-close-race-condition
branch
from
ce84e83
to
e73bf71
Compare
qzhuyan
reviewed
Nov 20, 2023
| @@ -1246,8 +1246,10 @@ handle_info( | |||
| {ok, Channel3} -> {ok, ?REPLY_EVENT(disconnected), Channel3}; | |||
| Shutdown -> Shutdown | |||
| end; | |||
| handle_info({sock_closed, Reason}, Channel = #channel{conn_state = disconnected}) -> | |||
| ?SLOG(error, #{msg => "unexpected_sock_close", reason => Reason}), | |||
| handle_info({sock_closed, _Reason}, Channel = #channel{conn_state = disconnected}) -> | |||
There was a problem hiding this comment.
I remember we also translate MQTT.disconnect to sock_closed some where.
Need double check
There was a problem hiding this comment.
we do, it's in emqx_connection.erl.
it's one of the causes of this race:
- receive
DISCONNECT(being processed), andtcp_closed(in the mailbox) - handle
DISCONNECTas: a) close socket, b) markconn_stateasdisconnected - handle
tcp_closedatdisconnectedstate.
qzhuyan
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #11812 and EMQX-11369
In some cases, EMQX may decide to close socket and mark connection at 'disconnected' state, for example, when DISCONNECTE packet is received, or, when failed to write data to socket. However, by the time EMQX decided to close the socket, the socket might have already been closed by peer, and the
tcp_closedenvet is already delivered to the process mailbox -- causing EMQX to handle sock_close event at 'disconnected' state.This PR removes the error level log.
Summary
馃[deprecated] Generated by Copilot at eff79b3
Refactor and fix bugs in channel modules for MQTT and STOMP gateways. Remove error log for socket close race condition in
emqx_channel.erland updateemqx_mqtt_channel.erlandemqx_stomp_channel.erlto use the new channel API.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update