EMQX-11319 data backup http api #12017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeTupchiy
force-pushed
the
EMQX-11319-data-backup-http-api
branch
from
e9fc99b
to
eae6037
Compare
SergeTupchiy
changed the title
SergeTupchiy
force-pushed
the
EMQX-11319-data-backup-http-api
branch
from
eae6037
to
e820ec8
Compare
SergeTupchiy
requested review from
lafirest,
sstrigler and
a team
as code owners
SergeTupchiy
force-pushed
the
EMQX-11319-data-backup-http-api
branch
2 times, most recently
from
723db0b
to
9998c06
Compare
SergeTupchiy
force-pushed
the
EMQX-11319-data-backup-http-api
branch
from
9998c06
to
89fdbf3
Compare
SergeTupchiy
commented
Nov 27, 2023
| FileNode -> | ||
| CoreNode = core_node(FileNode), | ||
| response( | ||
| emqx_mgmt_data_backup_proto_v1:import_file(CoreNode, FileNode, FileName, infinity) |
There was a problem hiding this comment.
Only core node is allowed to import a backup, because it implies using mnesia:restore/2. Calling it on a replicant node would mean that Mnesia data is only restored locally.
SergeTupchiy
commented
Nov 27, 2023
|
|
||
| list_backup_files(Page, Limit) -> | ||
| Start = Page * Limit - Limit + 1, | ||
| lists:sublist(list_backup_files(), Start, Limit). |
There was a problem hiding this comment.
Naive paging, but I think the number of stored backup files is not expected to be very large...
Additionally, this simply lists *.tar.gz files in <emqx data dir>/backup. Adding some Mnesia DB layer for backups is possible but it would be hard to keep it in sync with FS state, especially taking into account the fact that users can directly manage backup dir without the dashboard..
ieQu1
approved these changes
Nov 27, 2023
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update