Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements async query mode for GreptimeDB data bridge #12072

Merged
merged 10 commits into from Dec 7, 2023

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Dec 1, 2023

Fixes

Release version: v/e5.?

Summary

Main changes:

  • Upgrade greptimedb to version 0.4.4 in CI workflow.
  • Upgrade greptimedb Erlang client to version 0.1.6 which supports asynchronous writing and fixes some bugs.
  • Supports asynchronous query mode for emqx_bridge_greptimedb, which will have better performance.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@killme2008 killme2008 requested a review from a team as a code owner December 1, 2023 09:33
@killme2008 killme2008 marked this pull request as draft December 1, 2023 09:33
@killme2008 killme2008 force-pushed the feature/greptimedb-async-write branch from 391db7d to 3ab6679 Compare December 4, 2023 08:50
@killme2008 killme2008 marked this pull request as ready for review December 4, 2023 08:50
@killme2008 killme2008 changed the title feat: upgrade greptimedb and implements async mode for data bridge feat: implements async query mode for GreptimeDB data bridge Dec 4, 2023
@killme2008 killme2008 force-pushed the feature/greptimedb-async-write branch from 17ffeff to 51bfdcd Compare December 4, 2023 09:36
@HJianBo HJianBo requested a review from thalesmg December 4, 2023 09:47
@killme2008 killme2008 force-pushed the feature/greptimedb-async-write branch from d9507a1 to 9920841 Compare December 4, 2023 12:30
@killme2008
Copy link
Contributor Author

@lafirest @thalesmg Please take a look when you are free, thank you.

@HJianBo HJianBo merged commit bd985e5 into emqx:master Dec 7, 2023
162 checks passed
@killme2008 killme2008 deleted the feature/greptimedb-async-write branch December 8, 2023 02:32
@killme2008
Copy link
Contributor Author

Thank you @HJianBo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants