ci: upgrade to otp 26 #12085
Merged
ci: upgrade to otp 26 #12085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
1201-otp-26-in-ci
branch
from
7afa0cb
to
c2269a6
Compare
zmstone
force-pushed
the
1201-otp-26-in-ci
branch
from
c2269a6
to
6fdd338
Compare
zmstone
force-pushed
the
1201-otp-26-in-ci
branch
5 times, most recently
from
f402211
to
893acd9
Compare
ieQu1
previously approved these changes
Dec 12, 2023
zmstone
force-pushed
the
1201-otp-26-in-ci
branch
9 times, most recently
from
a93ce04
to
685dd8a
Compare
zmstone
force-pushed
the
1201-otp-26-in-ci
branch
2 times, most recently
from
ed164d8
to
b234d7f
Compare
dialyzer fix and mix file fix
On OTP 26, cacerts or cacertfile must be provided when verify_peer
- upgraded from 3.7.0-emqx-2 - 3.7.0.3 is a dependency upgrade: - lhttpc upgraded from 1.6.2 to 1.6.3 - lhttpc 1.6.3 fixed otp 26 compatibility
otherwise it will raise an exit exception
zmstone
force-pushed
the
1201-otp-26-in-ci
branch
from
2ce5ae2
to
e45ed3d
Compare
zmstone
requested review from
Rory-Z,
savonarola,
keynslug,
JimMoen and
lafirest
as code owners
Rory-Z
approved these changes
Dec 15, 2023
keynslug
approved these changes
Dec 15, 2023
| @@ -66,7 +66,7 @@ | |||
| {plt_location, "."}, | |||
| {plt_prefix, "emqx_dialyzer"}, | |||
| {plt_apps, all_apps}, | |||
| {plt_extra_apps, [hocon]}, | |||
| {plt_extra_apps, [hocon,mnesia,bcrypt,os_mon,pbkdf2,emqx_http_lib, recon]}, | |||
There was a problem hiding this comment.
Strange that we now need to do that, some of them probably need to be added to the emqx.app.src?
There was a problem hiding this comment.
mainly for two reasons
- apps (e.g. mnesia) need to be added to all apps which calls mnesia, this is a bit annoying
- apps (e.g. hocon, bcrpyt(when using nif), emqx_http_lib) they are static libs dummy root sup or no root sup at all.
There was a problem hiding this comment.
Understood.
they are static libs dummy root sup or no root sup at all.
Even then, a lot of stuff treats entries in app.src as dependencies that need to be taken into account, not just dialyzer (i.e., relx).
There was a problem hiding this comment.
Sorry. this is actually just for the standalone app.
Will fix it in the next PR.
There was a problem hiding this comment.
and maybe bcrypt is not needed to be dynamic dep since we dropped windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11510
Release version: v/e5.4.0
Summary
Build 5.4 on OTP 26.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update