Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: upgrade to wolff 1.9.1 for better performance #12194

Merged
merged 1 commit into from Dec 18, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Dec 18, 2023

Fixes EMQX-11297
Release version: v/e5.5.0

Summary

Upgrade from 1.8.0:

  • wollf-1.9.0 has the global stats disabled by default
  • wolff-1.9.1 improved client pid lookup performance

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone force-pushed the 1218-perf-upgrade-wolff branch 2 times, most recently from 9d53934 to 14e7378 Compare December 18, 2023 17:40
Upgrade from 1.8.0:
- wollf-1.9.0 has the global stats disabled by default
- wolff-1.9.1 improved client pid lookup performance
@zmstone zmstone marked this pull request as ready for review December 18, 2023 19:02
@zmstone zmstone requested a review from a team as a code owner December 18, 2023 19:02
@zmstone zmstone merged commit da92e62 into emqx:master Dec 18, 2023
163 checks passed
@zmstone zmstone deleted the 1218-perf-upgrade-wolff branch December 18, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants