feat(listen): support hot config update of MQTT listeners #12201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynslug
force-pushed
the
feat/EMQX-11527/tls-hot-update
branch
2 times, most recently
from
d12d631
to
7daa1b6
Compare
keynslug
changed the title
These options have not been picked up by the listener before esockd 5.11.0, so it was not apparent that they are not working.
With a typespec fix.
However, currently any transport option changes will cause listener to restart, which slightly impacts the availability of the broker.
keynslug
force-pushed
the
feat/EMQX-11527/tls-hot-update
branch
from
7daa1b6
to
7e40496
Compare
zmstone
reviewed
Dec 19, 2023
zmstone
previously approved these changes
Dec 19, 2023
qzhuyan
reviewed
Dec 19, 2023
| emqx_listeners:stop_listener(ssl, ?FUNCTION_NAME, LConf). | ||
| ClientSSLOpts = [ | ||
| {verify, verify_peer}, | ||
| {cacertfile, CACertfile}, |
There was a problem hiding this comment.
Hm, but the point is that the server is not yet verifying peers.
qzhuyan
reviewed
Dec 19, 2023
qzhuyan
reviewed
Dec 19, 2023
qzhuyan
reviewed
Dec 19, 2023
keynslug
force-pushed
the
feat/EMQX-11527/tls-hot-update
branch
from
b9c0442
to
baf46c9
Compare
zmstone
approved these changes
Dec 20, 2023
qzhuyan
reviewed
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of EMQX-11527.
Part of EMQX-11528.
Release version: v5.4
Shortcomings / TODOs
bindtcp_options.backlogtcp_options.reuseaddrSummary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles