Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to gen_rpc 3.3.1 which does not log cast args only arity #12202

Merged
merged 1 commit into from Dec 19, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Dec 19, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-11595

Release version: v/e5.4.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested review from lafirest and a team as code owners December 19, 2023 11:40
@zmstone
Copy link
Member Author

zmstone commented Dec 19, 2023

will not add change log because there is already one for upgrading to 3.3.0

@zmstone zmstone merged commit 9e24d08 into emqx:release-54 Dec 19, 2023
163 checks passed
@zmstone zmstone deleted the 1219-upgrade-gen_rpc-3.3.1 branch December 19, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants