Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not expose 11883 by default in docker as we do not listen on it #12246

Merged
merged 2 commits into from Jan 4, 2024

Conversation

id
Copy link
Collaborator

@id id commented Jan 2, 2024

Fixes EMQX-11172

Release version: v/e5.4.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@id id requested review from Rory-Z and a team as code owners January 2, 2024 08:05
@id id force-pushed the 0102-docker-do-not-expose-11883 branch from 11c60b3 to 1649f67 Compare January 2, 2024 09:07
@HJianBo HJianBo merged commit b4c4103 into emqx:release-54 Jan 4, 2024
162 checks passed
@id id deleted the 0102-docker-do-not-expose-11883 branch January 4, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants