fix(ds): Don't start the supervision tree when feature is off #12264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieQu1
force-pushed
the
avoid-starting-ds-when-feature-is-off
branch
from
806265c
to
d454a1d
Compare
zmstone
previously approved these changes
Jan 8, 2024
|
It seems the default value is expected differently in some test cases. |
ieQu1
force-pushed
the
avoid-starting-ds-when-feature-is-off
branch
3 times, most recently
from
fb2c1a3
to
95ce92a
Compare
zmstone
reviewed
Jan 8, 2024
ieQu1
force-pushed
the
avoid-starting-ds-when-feature-is-off
branch
from
95ce92a
to
a9c99cc
Compare
ieQu1
force-pushed
the
avoid-starting-ds-when-feature-is-off
branch
2 times, most recently
from
d89b3a3
to
1cdcda5
Compare
ieQu1
commented
Jan 8, 2024
| ensure_workers() -> | ||
| ChildSpec = #{ | ||
| id => workers_sup, | ||
| restart => temporary, |
There was a problem hiding this comment.
I guess it's better this way while the feature is still experimental.
keynslug
previously approved these changes
Jan 8, 2024
ieQu1
force-pushed
the
avoid-starting-ds-when-feature-is-off
branch
from
1cdcda5
to
eb7287f
Compare
ieQu1
force-pushed
the
avoid-starting-ds-when-feature-is-off
branch
from
eb7287f
to
caf461f
Compare
zmstone
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11692
Release version:
v/e5.4.1Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update