feat(cluster): supports inviting nodes to join the cluster in an asynchronous manner #12267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJianBo
force-pushed
the
new-timeout-param-for-invite
branch
2 times, most recently
from
4879e83
to
fe38629
Compare
HJianBo
changed the title
HJianBo
force-pushed
the
new-timeout-param-for-invite
branch
from
c0e5d66
to
c9b9662
Compare
savonarola
reviewed
Jan 12, 2024
| invite_node(put, #{bindings := #{node := Node0}, body := Body}) -> | ||
| Node = ekka_node:parse_name(binary_to_list(Node0)), | ||
| case maps:get(<<"timeout">>, Body, ?DEFAULT_INVITE_TIMEOUT) of | ||
| T when not is_integer(T) -> |
There was a problem hiding this comment.
Nit: could that be verified with schema?
There was a problem hiding this comment.
In theory, it really should. But for the moment, I haven't found a suitable example to check the format of a field request via schema. 😭
savonarola
reviewed
Jan 12, 2024
savonarola
previously approved these changes
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
zmstone
reviewed
Jan 12, 2024
Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
HJianBo
force-pushed
the
new-timeout-param-for-invite
branch
from
cfc3065
to
4b3ecff
Compare
HJianBo
force-pushed
the
new-timeout-param-for-invite
branch
from
e5a7188
to
4c40e75
Compare
Comment on lines
+47
to
50
| "/cluster/invitation", | ||
| "/cluster/:node/invite", | ||
| "/cluster/:node/invite_async", | ||
| "/cluster/:node/force_leave" |
There was a problem hiding this comment.
Maybe we should add async option to invite instead of introduce a new api ?
zmstone
previously approved these changes
Jan 15, 2024
Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
could you double check the ticket/issue? it refers to this PR? |
zhongwencool
approved these changes
Jan 16, 2024
terry-xiaoyu
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-11690
Release version: v/e5.5.0
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesCreated PR to emqx-docs if documentation update is required, or link to a follow-up jira ticketChecklist for CI (.github/workflows) changes
If changed package build workflow, pass this action (manual trigger)changes/dir for user-facing artifacts update