EMQX-9700 improve observability #12299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimMoen
changed the title
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
2 times, most recently
from
57c645e
to
5db76c6
Compare
JimMoen
commented
Jan 11, 2024
JimMoen
commented
Jan 11, 2024
JimMoen
commented
Jan 11, 2024
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
from
5db76c6
to
4dc4ec4
Compare
| NCluster#{license_quota => V}; | ||
| %% for cluster sample, ignore node_uptime | ||
| (node_uptime, _V, NCluster) -> | ||
| NCluster; |
There was a problem hiding this comment.
Maybe include this uptime in the Prometheus metrics as well. It would be very useful!
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
from
4dc4ec4
to
e4b798f
Compare
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
from
e4b798f
to
9e01d10
Compare
JimMoen
commented
Jan 14, 2024
HJianBo
reviewed
Jan 15, 2024
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
2 times, most recently
from
776bd75
to
62a7346
Compare
JimMoen
commented
Jan 15, 2024
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
5 times, most recently
from
4e26020
to
5493080
Compare
JimMoen
commented
Jan 18, 2024
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
from
75917b1
to
5b6c948
Compare
- `retained_msg_count` Current retained_msg_count on each node and should be same on all nodes. - `license_quota` Only for enterprise edition, provides the max limited connections num.
- rm rate fields - fix few fields type to counter
- node(default):
The only supported format_mode for PushGateway.
Return the current node's metrics.
- Without label `node_name` with content-type: `text/plain`.
- Without key `node_name` with content-type: `application/json`
- nodes_aggregated:
Return all nodes metrics Arithmetic-Sum or Logical-Sum.
See details in callback modules.
- Logical-Sum for metrics named with `xxx_enable` or `xxx_status`.
- Arithmetic-Sum for other metrics.
`node_name` field:
- Without label `node_name` with content-type: `text/plain`.
- Without key `node_name` with content-type: `application/json`
- nodes_unaggregated:
Return all nodes metrics without aggregated.
`node_name` field:
- _With_ label `node_name` with content-type: `text/plain`.
- _With_ key `node_name` with content-type: `application/json`
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
2 times, most recently
from
33d4621
to
d423762
Compare
HJianBo
previously approved these changes
Jan 22, 2024
JimMoen
force-pushed
the
EMQX-9700-improve-observability
branch
from
871ba9a
to
c2f26e8
Compare
HJianBo
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-9700
Release version: v/e5.5.0
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
If changed package build workflow, pass this action (manual trigger)changes/dir for user-facing artifacts update