Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot write literal numbers to influxdb #12301

Merged
merged 2 commits into from Jan 15, 2024
Merged

fix: cannot write literal numbers to influxdb #12301

merged 2 commits into from Jan 15, 2024

Conversation

terry-xiaoyu
Copy link
Contributor

@terry-xiaoyu terry-xiaoyu commented Jan 11, 2024 •
edited

Fixes https://emqx.atlassian.net/browse/EMQX-11637

Release version: e5.5

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@terry-xiaoyu terry-xiaoyu requested review from JimMoen and a team as code owners January 11, 2024 10:23
@terry-xiaoyu terry-xiaoyu force-pushed the influxdb_line_protocol branch 4 times, most recently from 2378ecc to dd6b214 Compare January 12, 2024 12:11
zmstone
zmstone previously approved these changes Jan 12, 2024
View reviewed changes
JimMoen
JimMoen requested changes Jan 13, 2024
View reviewed changes
Copy link
Member

@JimMoen JimMoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and change merge target to release-55

@terry-xiaoyu terry-xiaoyu changed the base branch from master to release-55 January 15, 2024 01:29
@terry-xiaoyu terry-xiaoyu merged commit c3fca04 into release-55 Jan 15, 2024
164 of 165 checks passed
@terry-xiaoyu terry-xiaoyu deleted the influxdb_line_protocol branch January 15, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo approved these changes

@Rory-Z Rory-Z Rory-Z approved these changes

@lafirest lafirest lafirest approved these changes

@JimMoen JimMoen JimMoen approved these changes

@zmstone zmstone zmstone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@terry-xiaoyu @zmstone @HJianBo @Rory-Z @lafirest @JimMoen