fix(bridge_api): correctly deobfuscate secrets during dry run #12306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
fix-password-deobfuscate-m-20240111
branch
2 times, most recently
from
eae8312
to
d5eb075
Compare
thalesmg
force-pushed
the
fix-password-deobfuscate-m-20240111
branch
from
d5eb075
to
79a4a04
Compare
ieQu1
reviewed
Jan 11, 2024
| @@ -999,6 +1000,8 @@ t_reset_bridges(Config) -> | |||
| {ok, 200, []} = request_json(get, uri(["bridges"]), Config). | |||
|
|
|||
| t_with_redact_update(Config) -> | |||
| ok = snabbkaffe:start_trace(), | |||
There was a problem hiding this comment.
It's better to use ?check_trace macro.
There was a problem hiding this comment.
I'll fix it in a follow up.
There was a problem hiding this comment.
Actually, we still have to call snabbkaffe:stop() when using that macro, right?
savonarola
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-11733
Release version: v/e5.5
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update