Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mongodb_action): make batch_size hidden and fixed in the API #12317

Merged
merged 1 commit into from Jan 12, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Jan 12, 2024

Fixes https://emqx.atlassian.net/browse/ED-1171

The old bridge schema already had this override, but it had not been ported to actions.

Release version: v/e5.5

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the fix-mongo-batch-schema-m-20240112 branch from a61e2d2 to cc4030d Compare January 12, 2024 12:40
Fixes https://emqx.atlassian.net/browse/ED-1171

The old bridge schema already had this override, but it had not been ported to actions.
@thalesmg thalesmg force-pushed the fix-mongo-batch-schema-m-20240112 branch from cc4030d to a5e7db7 Compare January 12, 2024 13:04
@thalesmg thalesmg marked this pull request as ready for review January 12, 2024 13:46
@thalesmg thalesmg requested a review from a team as a code owner January 12, 2024 13:46
@thalesmg thalesmg merged commit 4736012 into emqx:master Jan 12, 2024
164 checks passed
@thalesmg thalesmg deleted the fix-mongo-batch-schema-m-20240112 branch January 12, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants