Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'tags' field for action and connector #12333

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Jan 16, 2024

Fixes EMQX-11752

Release version: v/e5.5.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone force-pushed the 0116-add-tags-for-action-and-connectors branch from 9dfb245 to a1789fc Compare January 16, 2024 12:38
@zmstone zmstone force-pushed the 0116-add-tags-for-action-and-connectors branch from a1789fc to ab66986 Compare January 16, 2024 12:57
@zmstone zmstone marked this pull request as ready for review January 16, 2024 14:53
@zmstone zmstone requested review from JimMoen, a team and lafirest as code owners January 16, 2024 14:53
thalesmg
thalesmg previously approved these changes Jan 16, 2024
apps/emqx/src/emqx_schema.erl Outdated Show resolved Hide resolved
Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
@zmstone zmstone merged commit 4fa9067 into emqx:release-55 Jan 16, 2024
163 of 164 checks passed
@zmstone zmstone deleted the 0116-add-tags-for-action-and-connectors branch January 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants