feat: refactor kinesis bridge to connector and action #12376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellwinblad
force-pushed
the
kjell/kinesis
branch
from
6003ae9
to
fa84273
Compare
thalesmg
reviewed
Jan 24, 2024
apps/emqx_bridge_kinesis/src/emqx_bridge_kinesis_action_info.erl
Outdated
Show resolved
Hide resolved
apps/emqx_bridge_kinesis/src/emqx_bridge_kinesis_impl_producer.erl
Outdated
Show resolved
Hide resolved
HJianBo
reviewed
Jan 29, 2024
| fields(kinesis_action) -> | ||
| emqx_bridge_v2_schema:make_producer_action_schema( | ||
| hoconsc:mk( | ||
| hoconsc:ref(?MODULE, action_parameters), |
There was a problem hiding this comment.
It will introduce a duplicated field local_topic for actions creating. e.g:
| emqx_connector_schema:api_fields( | ||
| Field, | ||
| ?CONNECTOR_TYPE, | ||
| connector_config_fields() |
There was a problem hiding this comment.
Missing the resource_opts configuration
e.g:
emqx/apps/emqx_bridge_mongodb/src/emqx_bridge_mongodb.erl
Lines 53 to 56 in dbe2baa
kjellwinblad
added a commit
to kjellwinblad/emqx
that referenced
this pull request
Jan 29, 2024
This commit fixes problems in schema found by @HJianBo here: emqx#12376 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://emqx.atlassian.net/browse/EMQX-11461
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles