Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor greptimedb bridge (split to actions and connectors) #12386

Merged

Conversation

SergeTupchiy
Copy link
Contributor

@SergeTupchiy SergeTupchiy commented Jan 24, 2024

Fixes EMQX-11457

Release version: v/e5.?

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy requested review from JimMoen and a team as code owners January 24, 2024 19:17
@SergeTupchiy SergeTupchiy force-pushed the EMQX-11457-bridge-v2-greptimedb branch from 3bb5463 to 6635e7f Compare January 24, 2024 19:27
@SergeTupchiy SergeTupchiy force-pushed the EMQX-11457-bridge-v2-greptimedb branch from 6635e7f to 51a0df8 Compare January 25, 2024 11:05
Copy link
Contributor

@thalesmg thalesmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
LGTM.
We just need to update the dependency ref once the PR is merged (or use our fork if that takes too long).

@SergeTupchiy SergeTupchiy force-pushed the EMQX-11457-bridge-v2-greptimedb branch from 51a0df8 to a56a5e9 Compare January 26, 2024 09:01
@SergeTupchiy
Copy link
Contributor Author

Thanks @thalesmg. Greptime team approved my PR and tagged the new release, so I've already removed my fork from rebar/mix deps.

@SergeTupchiy SergeTupchiy merged commit 017386f into emqx:master Jan 26, 2024
165 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants