0130 limit kafka partitions #12427
Merged
0130 limit kafka partitions #12427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0130-limit-kafka-partitions
branch
2 times, most recently
from
fa9d2d0
to
b2d5252
Compare
zmstone
force-pushed
the
0130-limit-kafka-partitions
branch
from
6f5ac01
to
46a3537
Compare
qzhuyan
previously approved these changes
Jan 30, 2024
thalesmg
previously approved these changes
Jan 30, 2024
| mk( | ||
| hoconsc:union([all_partitions, pos_integer()]), | ||
| #{ | ||
| default => <<"all_partitions">>, |
There was a problem hiding this comment.
I thought that the default value for atoms should be atoms. Is it indifferent in this case?
HJianBo
reviewed
Jan 31, 2024
zmstone
force-pushed
the
0130-limit-kafka-partitions
branch
from
6607b2f
to
8ab29ac
Compare
zmstone
force-pushed
the
0130-limit-kafka-partitions
branch
from
8ab29ac
to
3b42a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11753 and EMQX-11652
Release version:
v/e5.6.0Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update