fix(bridge_v2_api): avoid calling nodes that do not support minimum bpapi #12472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
fix-bridgev2-api-multicall-m-20240202
branch
from
f96bb6d
to
1cf08d7
Compare
thalesmg
force-pushed
the
fix-bridgev2-api-multicall-m-20240202
branch
from
1cf08d7
to
76d242d
Compare
thalesmg
commented
Feb 2, 2024
| @@ -1477,7 +1476,7 @@ t_cluster_later_join_metrics(Config) -> | |||
| ?assertMatch( | |||
| {ok, 200, #{ | |||
| <<"metrics">> := #{<<"success">> := _}, | |||
| <<"node_metrics">> := [#{<<"metrics">> := #{}}, #{<<"metrics">> := #{}} | _] | |||
There was a problem hiding this comment.
Returns a single node result now, because BPAPI might not be ready / not have announced the new node's APIs yet, and thus is rejected when choosing the nodes.
|
I think these read operations might not be too affected by sieving the node list: when the rolling upgrade finishes, the whole information will be returned. |
ieQu1
approved these changes
Feb 3, 2024
ieQu1
reviewed
Feb 3, 2024
| [cluster, actions], | ||
| [cluster, sources] | ||
| ]; | ||
| t_older_version_nodes_in_cluster(Config) -> |
There was a problem hiding this comment.
Is this testcase going to be relevant in the future releases? If not, perhaps a manual one-off test is enough?
There was a problem hiding this comment.
I think this still might be relevant for any rolling upgrade scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-11834
Release version: v/e5.6
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update