feat: refactor RocketMQ bridge to connector and action #12488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellwinblad
force-pushed
the
kjell/refactor/rocketmq_bridge/EMQX-11467
branch
2 times, most recently
from
a3c3310
to
e284a83
Compare
thalesmg
previously approved these changes
Feb 9, 2024
apps/emqx_bridge_rocketmq/src/emqx_bridge_rocketmq_connector.erl
Outdated
Show resolved
Hide resolved
|
Thanks @thalesmg for a good review. I fixed the issues that you pointed out. |
Thanks. I will have a look at emqx_bridge_v2_testlib. If we add such tests I think we can do it in another PR so we can get this merged. |
ieQu1
approved these changes
Feb 13, 2024
Comment on lines
+178
to
+183
| on_get_channel_status( | ||
| _ResId, | ||
| _ChannelId, | ||
| _State | ||
| ) -> | ||
| ?status_connected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://emqx.atlassian.net/browse/EMQX-11467
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles